]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
keyboard: Drop needless signal from OSK Key object
authorCarlos Garnacho <carlosg@gnome.org>
Thu, 14 Apr 2022 18:49:00 +0000 (20:49 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Wed, 10 Aug 2022 17:11:26 +0000 (17:11 +0000)
The 'pressed' signal will be emitted in the same circumstances now,
there's no need for a separate 'activated' signal.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2278>

js/ui/keyboard.js

index b51eeb413501c38fe26e388da97a84fdde717a78..44426b2255087da0b8980d6512471c48055e2bb5 100644 (file)
@@ -297,7 +297,6 @@ var LanguageSelectionPopup = class extends PopupMenu.PopupMenu {
 
 var Key = GObject.registerClass({
     Signals: {
-        'activated': {},
         'long-press': {},
         'pressed': {},
         'released': {},
@@ -356,8 +355,6 @@ var Key = GObject.registerClass({
     }
 
     _press(button) {
-        this.emit('activated');
-
         if (button === this.keyButton) {
             this._pressTimeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT,
                 KEY_LONG_PRESS_TIME,
@@ -907,7 +904,7 @@ var EmojiPager = GObject.registerClass({
 
             key.keyButton.set_button_mask(0);
 
-            key.connect('activated', () => {
+            key.connect('pressed', () => {
                 this._currentKey = key;
             });
             key.connect('long-press', () => {